Use local OKP embeddings from rag-content#116
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/controller/assets/vector_database_collect.sh`:
- Line 264: The cp command copying OKP_EMBEDDING_MODEL_SRC to
VECTOR_DB_VOLUME_MOUNT_PATH/okp_embeddings_model creates nested directories on
re-runs when the destination already exists (because cp copies the source into
an existing destination directory). Before the cp command, add a check to remove
the destination directory if it already exists using rm -rf, then perform the cp
operation. This ensures the directory structure remains flat and correct on
retries and upgrades without leaving stale files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ea6375f7-505d-4a0d-b223-455f7c674112
📒 Files selected for processing (9)
api/v1beta1/openstacklightspeed_types.gobundle/manifests/openstack-lightspeed-operator.clusterserviceversion.yamlconfig/manager/manager.yamlconfig/manifests/bases/openstack-lightspeed-operator.clusterserviceversion.yamlhack/env.shinternal/controller/assets/vector_database_collect.shinternal/controller/constants.gointernal/controller/lcore_deployment.gointernal/controller/llama_stack_config.go
💤 Files with no reviewable changes (1)
- internal/controller/lcore_deployment.go
umago
force-pushed
the
okp-embedding-model
branch
2 times, most recently
from
7b4e475 to
d9a05b1
Compare
|
/test openstack-lightspeed-kuttl-4-18 |
umago
force-pushed
the
okp-embedding-model
branch
from
d9a05b1 to
d9686fb
Compare
umago
force-pushed
the
okp-embedding-model
branch
2 times, most recently
from
2f81a86 to
2aa7dbe
Compare
umago
force-pushed
the
okp-embedding-model
branch
from
2aa7dbe to
5f0acd8
Compare
umago
force-pushed
the
okp-embedding-model
branch
from
5f0acd8 to
03d5acb
Compare
The rag-content image now ships the OKP embedding model in it and we no longer need for OGX to download it at runtime via HF. Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
umago
force-pushed
the
okp-embedding-model
branch
from
03d5acb to
6e607da
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 51ad0a6
into
openstack-lightspeed:lcore-migration
3 participants
The rag-content image now ships the OKP embedding model in it and we no longer need for OGX to download it at runtime via HF.
Summary by CodeRabbit
New Features
Chores